fix(oauth): route DCR reconnect through registration flow - #1559
Merged
RhysSullivan merged 13 commits intoAug 29, 2026
Conversation
Contributor
Author
|
@RhysSullivan have a look |
A dynamically registered OAuth client is bound to the redirect URI it registered with, so once the app's callback origin changed (127.0.0.1 to localhost) Reconnect kept starting the flow against the stored client and the authorization server rejected it, leaving no way to repair the connection. Reconnect now takes the same probe -> CIMD-or-register -> start route as the initial connect, sharing one runner rather than a second copy of the orchestration. Methods with a fixed, hand-registered app are unchanged. Fixes UsefulSoftwareCo#1542
…ients, abort automatic connect on modal close
…be, abort before failure fallbacks
… and retry data-less failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1542
A dynamically registered (DCR) OAuth client is tied to a specific redirect URI. When the app's callback origin changes (e.g. 127.0.0.1 to localhost), reconnecting a DCR-capable client using the stored redirect URI fails the authorization flow. This routes Reconnect through the same probe -> register-dynamic -> start flow as initial Connect, so the registration gateway handles replacing stranded clients when the redirect URI shifts.